Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/86_avoid-panic-in-ibc-begin-end #90

Merged
merged 4 commits into from
Oct 21, 2024

Conversation

InnerPeace080
Copy link
Collaborator

@InnerPeace080 InnerPeace080 commented Oct 4, 2024

Description

Avoid panic in abci logic end block distribution FundCommunityPoolFromModule

Closes: #86


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • tackled an existing issue or discussed with a team member
  • left instructions on how to review the changes
  • targeted the correct branch (see PR Targeting)

Reviewers Checklist

All items are required.
Please add a note if the item is not applicable
and please add your handle next to the items reviewed
if you only reviewed selected items.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed content
  • confirmed all CI checks have passed

@github-actions github-actions bot added the CLI label Oct 4, 2024
@InnerPeace080 InnerPeace080 requested a review from hugjobk October 21, 2024 06:49
Copy link
Collaborator

@hugjobk hugjobk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! except some typos

x/distribution/keeper/keeper.go Show resolved Hide resolved
x/distribution/keeper/keeper.go Show resolved Hide resolved
@InnerPeace080 InnerPeace080 merged commit 7b800b9 into develop Oct 21, 2024
14 checks passed
@InnerPeace080 InnerPeace080 deleted the feature/86_avoid-panic-in-ibc-begin-end branch October 21, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Avoid panic in ibc begin/end block
2 participants