Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Avoid panic in ibc begin/end block #86

Closed
InnerPeace080 opened this issue Aug 12, 2024 · 1 comment · Fixed by #90
Closed

[Feature]: Avoid panic in ibc begin/end block #86

InnerPeace080 opened this issue Aug 12, 2024 · 1 comment · Fixed by #90
Assignees
@InnerPeace080

Comments

@InnerPeace080
Copy link
Collaborator

Summary

Avoid panic when pass amount zero to SendCoinsFromModuleToModule in

Issue Definition

No response

Proposed Feature

Try to use method IsValid of sdk.Coins
@InnerPeace080 InnerPeace080 self-assigned this Oct 4, 2024
@InnerPeace080
Copy link
Collaborator Author

Can ignore https://github.com/titantkx/titan/blob/develop/x/validatorreward/keeper/distribute.go coz rewardAmount init by NewCoins that already have sanitizeCoins check (remove zero coins)

InnerPeace080 added a commit that referenced this issue Oct 4, 2024
@InnerPeace080
feature: Fixes #86 Avoid panic in ibc begin/end block (FundCommunityP…
c4e6333 
…oolFromModule)
@InnerPeace080 InnerPeace080 mentioned this issue Oct 4, 2024
Merged
6 tasks
@InnerPeace080 InnerPeace080 mentioned this issue Oct 22, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@InnerPeace080 InnerPeace080

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/86_avoid-panic-in-ibc-begin-end titantkx/titan
1 participant
@InnerPeace080