Decouple DeadlineMovingAverageModel from PerSegmentModelMixin
#1140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://deploy-preview-1140--etna-docs.netlify.app |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## inference-v2.1 #1140 +/- ##
=================================================
Coverage ? 86.87%
=================================================
Files ? 164
Lines ? 8985
Branches ? 0
=================================================
Hits ? 7806
Misses ? 1179
Partials ? 0 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
alex-hse-repository
suggested changes
Mar 1, 2023
| @@ -178,7 +188,7 @@ def test_deadline_model_predict_fail_not_enough_context(simple_df): | |||
| model = DeadlineMovingAverageModel(window=1000) | |||
| model.fit(simple_df) | |||
| with pytest.raises(ValueError, match="Given context isn't big enough"): | |||
| _ = model.forecast(simple_df, prediction_size=7) | |||
| _ = model.predict(simple_df, prediction_size=7) | |||
There was a problem hiding this comment.
Why did you replace method here?
There was a problem hiding this comment.
Look at the test name, it was an artifact of copypasta.
alex-hse-repository
approved these changes
Mar 2, 2023
This was referenced Mar 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting (must do checklist)
Proposed Changes
Look #1117.
Closing issues
Closes #1117.