Skip to content

Decouple DeadlineMovingAverageModel from PerSegmentModelMixin #1117

Closed
Mr-Geekman opened this issue Feb 15, 2023 · 1 comment
Closed

Decouple DeadlineMovingAverageModel from PerSegmentModelMixin #1117

Mr-Geekman opened this issue Feb 15, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Feb 15, 2023

🚀 Feature Request

We want to uncouple DeadlineMovingAverageModel from PerSegmentModelMixin. Doing this, we can make DeadlineMovingAverageModel predict on any new segments because it doesn't require fit to work.

It also can lead to better performance.

Proposal

  • Implement DeadlineMovingAverageModel without using PerSegmentModelMixin and NonPredictionIntervalContextRequiredModelMixin. It should be inherited only from NonPredictionIntervalContextRequiredAbstractModel.
  • Method get_model should return self.
  • Try to vectorize forecasting logic.

Test cases

  1. Make sure current tests pass.
  2. Adapt tests on _DeadlineMovingAverageModel.
  3. Fix test_inference tests to work on new segments.

Additional context

No response

@Mr-Geekman Mr-Geekman added the enhancement New feature or request label Feb 15, 2023
@Mr-Geekman Mr-Geekman added this to the Inference 2.1 milestone Feb 15, 2023
@github-project-automation github-project-automation bot moved this to Specification in etna board Feb 15, 2023
@Mr-Geekman Mr-Geekman changed the title Uncouple DeadlineMovingAverageModel from PerSegmentModelMixin Decouple DeadlineMovingAverageModel from PerSegmentModelMixin Feb 15, 2023
@Mr-Geekman Mr-Geekman moved this from Specification to Todo in etna board Feb 15, 2023
@Mr-Geekman Mr-Geekman self-assigned this Feb 28, 2023
@Mr-Geekman Mr-Geekman moved this from Todo to In Progress in etna board Feb 28, 2023
@Mr-Geekman Mr-Geekman moved this from In Progress to In Review in etna board Feb 28, 2023
@Mr-Geekman
Copy link
Contributor Author

Closed by #1140.

@github-project-automation github-project-automation bot moved this from In Review to Done in etna board Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
Status: Done
Development

No branches or pull requests

1 participant