Remove unused code #537
Merged
Remove unused code #537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobweinstock
added
priority/backlog
Codecov Report
@@ Coverage Diff @@
## master #537 +/- ##
=======================================
Coverage 33.61% 33.61%
=======================================
Files 44 44
Lines 3385 3385
=======================================
Hits 1138 1138
Misses 2150 2150
Partials 97 97 Continue to review full report at Codecov.
|
jacobweinstock
force-pushed
the
remove-unused-code
branch
from
d8577d2
to
0564183
Compare
Clean up. Also, helps so that there are no unneeded contributions against these files. If the functionality in test/ is needed it should be moved to the sandbox repo. These are full-stack tests, not just Tink server tests. Signed-off-by: Jacob Weinstock <[email protected]>
jacobweinstock
force-pushed
the
remove-unused-code
branch
from
0564183
to
ad86491
Compare
mmlb
approved these changes
Sep 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
General code clean-up.
Also, helps so that there are no unneeded contributions against these files.
If the functionality in
test/is needed it should be moved to the sandbox repo as it runs full-stack tests, not just Tink server tests.Why is this needed
Fixes: #526
Fixes: #367
Fixes: #306
Fixes: #257
Fixes: #90
Fixes: #533
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: