Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test/ directory purpose? #526

Closed
jacobweinstock opened this issue Aug 30, 2021 · 2 comments · Fixed by #537
Closed

test/ directory purpose? #526

jacobweinstock opened this issue Aug 30, 2021 · 2 comments · Fixed by #537
Labels
kind/support Categorizes issue or PR as a support question.

Comments

@jacobweinstock
Copy link
Member

jacobweinstock commented Aug 30, 2021

Hello. Does anyone have any details on the test/ directory? I don't see a Make target for it. test/e2e_test.go seems to possibly be an entry point for running the code, but it's all commented out. I don't see any CI that runs it either. Is it still in use somehow? If so, how do we run it? Is it maybe something that can be removed? or moved to the sandbox?

Tagging a few folks whose names I see as committers to those files to see if they possibly have some insight. @parauliya @mmlb @kqdeng

Expected Behaviour

Current Behaviour

Possible Solution

Steps to Reproduce (for bugs)

Context

Your Environment

  • Operating System and version (e.g. Linux, Windows, MacOS):

  • How are you running Tinkerbell? Using Vagrant & VirtualBox, Vagrant & Libvirt, on Packet using Terraform, or give details:

  • Link to your project or a code example to reproduce issue:

@jacobweinstock jacobweinstock added triage/discuss Indicates a PR or issue that requires discussion kind/support Categorizes issue or PR as a support question. labels Aug 30, 2021
@mmlb
Copy link
Contributor

mmlb commented Aug 31, 2021

Looks like old E2E tests that were commented instead of deleted. I'd say we rectify that.

@mmlb
Copy link
Contributor

mmlb commented Aug 31, 2021

The vagrant based tests used to be here too, according to git history, but those are gone now.

@jacobweinstock jacobweinstock mentioned this issue Sep 3, 2021
3 tasks
@tstromberg tstromberg removed the triage/discuss Indicates a PR or issue that requires discussion label Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/support Categorizes issue or PR as a support question.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants