Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change envrc to .env #483

Merged
merged 2 commits into from
Apr 20, 2021
Merged

Change envrc to .env #483

merged 2 commits into from
Apr 20, 2021

Conversation

gauravgahlot
Copy link
Contributor

Description

The setup scripts in tinkerbell/tink are different from that of tinkerbell/sandbox.

Why is this needed

Fixes: #481

Signed-off-by: Gaurav Gahlot <[email protected]>
@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #483 (a5266c9) into master (a56e5cf) will not change coverage.
The diff coverage is n/a.

❗ Current head a5266c9 differs from pull request most recent head c03a265. Consider uploading reports for the commit c03a265 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master     #483   +/-   ##
=======================================
  Coverage   32.09%   32.09%           
=======================================
  Files          44       44           
  Lines        3103     3103           
=======================================
  Hits          996      996           
  Misses       2017     2017           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a56e5cf...c03a265. Read the comment docs.

thebsdbox
thebsdbox previously approved these changes Apr 16, 2021
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM although I guess it's confusing that we have a generate-envrc.sh that doesn't generate anenvrc 😂

@gauravgahlot
Copy link
Contributor Author

/LGTM although I guess it's confusing that we have a generate-envrc.sh that doesn't generate anenvrc

Surely 😄 I will update it.

Signed-off-by: Gaurav Gahlot <[email protected]>
@gauravgahlot gauravgahlot requested review from thebsdbox and removed request for gianarb April 16, 2021 16:48
@gauravgahlot gauravgahlot self-assigned this Apr 16, 2021
@gauravgahlot gauravgahlot added the area/setup Issue related to tinkerbell setup label Apr 16, 2021
@gauravgahlot gauravgahlot added the ready-to-merge Signal to Mergify to merge the PR. label Apr 16, 2021
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sanitising these across the board.

@mergify mergify bot merged commit d13a368 into tinkerbell:master Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setup Issue related to tinkerbell setup ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

generate-envrc.sh writes to "envrc" insted of ".env"
2 participants