-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change envrc to .env #483
Change envrc to .env #483
Conversation
Signed-off-by: Gaurav Gahlot <[email protected]>
6f4c93c
to
1b68611
Compare
Codecov Report
@@ Coverage Diff @@
## master #483 +/- ##
=======================================
Coverage 32.09% 32.09%
=======================================
Files 44 44
Lines 3103 3103
=======================================
Hits 996 996
Misses 2017 2017
Partials 90 90 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/LGTM
although I guess it's confusing that we have a generate-envrc.sh
that doesn't generate anenvrc
😂
Surely 😄 I will update it. |
Signed-off-by: Gaurav Gahlot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sanitising these across the board.
Description
The setup scripts in
tinkerbell/tink
are different from that oftinkerbell/sandbox
.Why is this needed
Fixes: #481