Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate-envrc.sh writes to "envrc" insted of ".env" #481

Closed
lukaskalvenas opened this issue Apr 11, 2021 · 0 comments · Fixed by #483
Closed

generate-envrc.sh writes to "envrc" insted of ".env" #481

lukaskalvenas opened this issue Apr 11, 2021 · 0 comments · Fixed by #483

Comments

@lukaskalvenas
Copy link

As asked by @gauravgahlot I'm writing an issue/reminder that generate-envrc.sh should write to ".env" and "setup.sh" should also look for ".env" instead of "envrc" :-)
@gauravgahlot gauravgahlot mentioned this issue Apr 16, 2021
Merged
@mergify mergify bot closed this as completed in #483 Apr 20, 2021
mergify bot added a commit that referenced this issue Apr 20, 2021
@mergify
Change envrc to .env (#483)
d13a368 
## Description

The setup scripts in `tinkerbell/tink` are different from that of `tinkerbell/sandbox`.

## Why is this needed

Fixes: #481
@tstromberg tstromberg mentioned this issue Jul 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change envrc to .env gauravgahlot/tink
1 participant
@lukaskalvenas