enable MD and build in some network drivers #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swills
force-pushed
the
kernel-config-changes
branch
from
3cf86da
to
e87ab78
Compare
|
Awesome! Thanks for this change. |
|
Ping? |
|
What is the status of this? This is a great complement to #99 and I believe hook should move forward with building more hardware support directly into the kernel instead of relying on modules in the initramfs. Concerns may be that this increases the size of the kernel image however this should be balanced by a reduction in initramfs size. How can we move this forward? cc: @tstromberg @thebsdbox @storrgie @jkl92 |
thebsdbox
approved these changes
Dec 31, 2021
|
Yeah I'm happy with that summary. |
|
NIC drivers in init ramfs don't help when kernel command line includes ip=dhcp. |
|
hmmm.....Hey @thebsdbox, looks like the CI could use some help here if you have any cycles? |
thebsdbox
previously approved these changes
Jan 13, 2022
|
Something to do with mergify is blocking this.. 🙄 |
markjacksonfishing
previously approved these changes
Jan 13, 2022
|
@Mergifyio refresh |
✅ Pull request refreshed |
|
@Mergifyio refresh |
✅ Pull request refreshed |
I needed this for my setup, I think others might find them useful. I wanted to setup md raid, so needed the md stuff built in. And in order to netboot from certain hardware, the driver for the hardware has to be built in, so add that as well. Signed-off-by: Steve Wills <[email protected]>
mmlb
dismissed stale reviews from markjacksonfishing and thebsdbox
via
7c838e2
mmlb
force-pushed
the
kernel-config-changes
branch
from
e87ab78
to
7c838e2
Compare
jacobweinstock
approved these changes
Feb 8, 2022
jacobweinstock
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
8 tasks
mergify bot
added a commit
that referenced
this pull request
Aug 31, 2022
Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you. Requirements: - [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md) - [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security) - [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev) - [X] I am actively contributing to 1 or more Tinkerbell subprojects - [X] Reviewer for at least 1 month - [X] Shallow understanding of the technical goals and direction of the repository - [X] Shallow understanding of the technical domain of the repository - [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features PR Reviews #98 #89 #130 PR merges #118 #117 #116 #115 #59 Sponsor Request from @mmlb @thebsdbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I needed this for my setup, I think others might find them useful. I
wanted to setup md raid, so needed the md stuff built in. And in order
to netboot from certain hardware, the driver for the hardware has to be
built in, so add that as well.
Why is this needed
Enables using MD, fixes netboot on certain hardware
Fixes: #
How Has This Been Tested?
Yep, tested it on my hardware
How are existing users impacted? What migration steps/scripts do we need?
Shouldn't cause any issues
Checklist:
I have: