Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for Approver Role #141

Merged
merged 1 commit into from
Aug 31, 2022
Merged

Request for Approver Role #141

merged 1 commit into from
Aug 31, 2022

Conversation

jacobweinstock
Copy link
Member

Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you.

Requirements:

  • I have reviewed the community membership guidelines
  • I have enabled 2FA on my GitHub account
  • I have subscribed to the tinkerbell-contributors e-mail list
  • I am actively contributing to 1 or more Tinkerbell subprojects
  • Reviewer for at least 1 month
  • Shallow understanding of the technical goals and direction of the repository
  • Shallow understanding of the technical domain of the repository
  • Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features

PR Reviews
#98
#89
#130

PR merges
#118
#117
#116
#115
#59

Sponsor Request from
@mmlb
@thebsdbox

Hello. I would like to request moving from reviewer to approver role. I am looking for a sponsor from either @mmlb or @thebsdbox. Please and thank you.

Requirements:

- [X] I have reviewed the [community membership guidelines](https://github.com/tinkerbell/proposals/blob/main/proposals/0024/GOVERNANCE.md)
- [X] I have [enabled 2FA on my GitHub account](https://github.com/settings/security)
- [X] I have subscribed to the [tinkerbell-contributors e-mail list](https://lists.cncf.io/g/cncf-tinkerbell-dev)
- [X] I am actively contributing to 1 or more Tinkerbell subprojects
- [X] Reviewer for at least 1 month
- [X] Shallow understanding of the technical goals and direction of the repository
- [X] Shallow understanding of the technical domain of the repository
- [X] Reviewed or merged at least 3 substantial PRs to the codebase such as significant re-design or whole new features

PR Reviews
#98
#89
#130

PR merges
#118
#117
#116
#115
#59

Sponsor Request from
@mmlb 
@thebsdbox
@mmlb mmlb self-assigned this Aug 31, 2022
@mmlb mmlb added the ready-to-merge Signal to Mergify to merge the PR. label Aug 31, 2022
@mergify mergify bot merged commit 3aeed5e into main Aug 31, 2022
@mergify mergify bot deleted the approver-role-request branch August 31, 2022 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Signal to Mergify to merge the PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants