ci: Only push to quay if github.actor is not dependabot #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We skipped logging in to quay.io when github.actor is dependabot in [#96] but did not check if any pushes were attempted. This change will avoid that failure. This was missed in the subsequent dependabot PRs [#89] and [#95] because there was no branch protection setup and I added the ready-to-merge label so mergify merged it :(. I've added branch protection to require the actions to pass. [#89]: #89 [#95]: #95 [#96]: #96 Signed-off-by: Manuel Mendez <[email protected]>
tstromberg
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoids pushing to quay if the PR/push originates from dependabot.
Why is this needed
We skipped logging in to quay.io when github.actor is dependabot in #96 but
did not check if any pushes were attempted. This change will avoid that
failure.
This was missed in the subsequent dependabot PRs #89 and #95 because there
was no branch protection setup and I added the ready-to-merge label so mergify
merged it :(. I've added branch protection to require the actions to pass.
How Has This Been Tested?
CI