Skip to content

Commit

Permalink
ci: Only push to quay if github.actor is not dependabot (#97)
Browse files Browse the repository at this point in the history
## Description

Avoids pushing to quay if the PR/push originates from dependabot.

## Why is this needed

We skipped logging in to quay.io when github.actor is dependabot in [#96] but
did not check if any pushes were attempted. This change will avoid that
failure.

This was missed in the subsequent dependabot PRs [#89] and [#95] because there
was no branch protection setup and I added the ready-to-merge label so mergify
merged it :(. I've added branch protection to require the actions to pass.

[#89]: #89
[#95]: #95
[#96]: #96

## How Has This Been Tested?

CI
  • Loading branch information
mergify[bot] authored Nov 30, 2021
2 parents 07b0c29 + 2b56a28 commit 54bae38
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/push.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ jobs:
with:
context: ./bootkit/
platforms: linux/amd64,linux/arm64
push: true
push: ${{ github.actor != 'dependabot[bot]' }}
tags: quay.io/tinkerbell/hook-bootkit:0.0

- name: Build and push tink-docker
uses: docker/[email protected]
with:
context: ./tink-docker/
platforms: linux/amd64,linux/arm64
push: true
push: ${{ github.actor != 'dependabot[bot]' }}
tags: quay.io/tinkerbell/hook-docker:0.0

- uses: cachix/install-nix-action@v16
Expand Down

0 comments on commit 54bae38

Please sign in to comment.