App/folder structure #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ninaolo
suggested changes
Aug 17, 2018
There was a problem hiding this comment.
Great that you found the solution for the GitHub highlighting issue 👍 🙂 Just some comments:
- Since this was a while ago (sorry for not addressing this PR) there's a conflict to be resolved.
- While you're at it, could you make two separate PRs for folder structure and syntax highlighting? And cherry pick the commits.
- Also, we'd prefer no broken commits, so please squash the broken commits you had there.
mlenser
force-pushed
the
client-structure-and-jsx
branch
2 times, most recently
from
c2be00a to
6404569
Compare
mlenser
previously approved these changes
Sep 28, 2018
|
@bailer Nice to see you again Snakob! |
mlenser
force-pushed
the
client-structure-and-jsx
branch
from
6404569 to
aaeb895
Compare
mlenser
approved these changes
Sep 28, 2018
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the filename extensions of the react components to
.jsxto make it easier for text editors to correctly select JSX syntax highlighting and to solve #2.Also put the react components and util file into a separate folders to clean up the structure a bit.