Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github read-ability. #2

Closed
JohnLindahlTech opened this issue Apr 19, 2018 · 2 comments
Closed

Github read-ability. #2

JohnLindahlTech opened this issue Apr 19, 2018 · 2 comments

Comments

@JohnLindahlTech
Copy link

https://github.com/tink-ab/tink-connect-example/blob/master/client/src/Callback.js has an issue with the ' which makes the file unnecessary hard to read. Consider changing don't to do not.

screen shot 2018-04-19 at 08 40 45
@bailer bailer mentioned this issue May 23, 2018
Merged
@bailer
Copy link
Contributor

bailer commented May 23, 2018

The reason it breaks is because Github doesn't parse it as JSX since it's written in a .js file instead of .jsx. See github-linguist/linguist#3144 and github-linguist/linguist#3677.
I would consider converting the files to .jsx instead which also makes it easier for text editors to use the correct syntax highlighting.

@ninaolo
Copy link
Contributor

ninaolo commented Oct 5, 2018

This should have been solved in this PR: #6 🙂

@ninaolo ninaolo closed this as completed Oct 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bailer @JohnLindahlTech @ninaolo