Skip to content

Commit

Permalink
Suggest only if the callee matches the trigger (#247)
Browse files Browse the repository at this point in the history
The issue here is a call to
    hvcat(rows::Tuple{Vararg{Int}}, xs::_DenseConcatGroup...) = Base.typed_hvcat(promote_eltype(xs...), rows, xs...)
which has a couple of `Core._apply_iterate` and the matching fails
when it doesn't match the trigger `promote_eltype`.
I tried to come up with a MWE but failed.

Fixes #244
  • Loading branch information
timholy authored Jul 18, 2021
1 parent c549ba5 commit f412a41
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions src/parcel_snoopi_deep.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,7 @@ function suggest(itrig::InferenceTrigger)
push!(s.categories, CalleeVariable)
end
if isa(calleef, Function)
nameof(calleef) == rtcalleename || continue
# if isa(argtyps, Core.Argument)
# argtyps = unwrapconst(ct.slottypes[argtyps.n])
# elseif isa(argtyps, Core.SSAValue)
Expand Down

0 comments on commit f412a41

Please sign in to comment.