Detect changes in performance annotations (fixes #165) #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #169 +/- ##
=========================================
Coverage ? 88.88%
=========================================
Files ? 9
Lines ? 567
Branches ? 0
=========================================
Hits ? 504
Misses ? 63
Partials ? 0
Continue to review full report at Codecov.
|
timholy
force-pushed
the
teh/perf_annotations
branch
from
dadb8cc to
77a405d
Compare
This was referenced Aug 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not quite sure if and when this changed (it clearly wasn't being tested), but a prime suspect is the switch to computing signature types. At any rate, this fixes the problem and adds good tests so this won't regress.
CC @quinnj.