Update for recent changes/opportunities in Revise #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures that Rebugger does the same thing as a normal call when stepping into Base methods. If the user hasn't said `Revise.track(Base)` previously in the session, then without activating Rebugger the call would have done whatever Base *as built* would have done. It's better if Rebugger produces the same result. This also prevents a major slowdown when stepping into Base methods (see Revise issue 168).
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=========================================
Coverage ? 84.06%
=========================================
Files ? 4
Lines ? 320
Branches ? 0
=========================================
Hits ? 269
Misses ? 51
Partials ? 0
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR accommodates Revise's new behavior with regards to
@inlineand other annotations (timholy/Revise.jl#169), and takes advantage of the fix (timholy/Revise.jl#170) for the poor performance ofRevise.track(Base)on some binary downloads (timholy/Revise.jl#168).