Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "Switch to inputDigest tagger" #146

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Conversation

timebertt
Copy link
Owner

Reverts #136

It seems skaffold v2.10.1 didn't solve the problem where it doesn't rebuild images although sources have changed (ref GoogleContainerTools/skaffold#9248).

Using the inputDigest tagger doesn't seem like a bad option after all anyway, so let's keep it.

@timebertt timebertt enabled auto-merge (squash) February 11, 2024 11:55
@timebertt timebertt merged commit 3f5e623 into main Feb 11, 2024
5 checks passed
@timebertt timebertt deleted the revert-136-skaffold-tagging branch February 11, 2024 11:57
@timebertt timebertt added the no-release-note This PR doesn't need to be listed in release notes. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-release-note This PR doesn't need to be listed in release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant