Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lookupRemote function may always return found when the same tag is reused #9248

Closed
yudppp opened this issue Jan 10, 2024 · 0 comments · Fixed by #9278
Closed

lookupRemote function may always return found when the same tag is reused #9248

yudppp opened this issue Jan 10, 2024 · 0 comments · Fixed by #9278
Labels
kind/bug Something isn't working priority/p1 High impact feature/bug.

Comments

@yudppp
Copy link

yudppp commented Jan 10, 2024

Hi, I'm @yudppp.

This is my first time submitting an issue to this project.

If the format is incorrect, please let me know.

Expected behavior

The lookupRemote function should return found if and only if the image with the given tag and digest exists in the cache. If the digests are different, even if the tags are the same, the function should return needsRemoteTagging.

This ensures that the user always builds the image they intend to build, even if the same tag is reused with a different digest.

Actual behavior

The actual behavior of the lookupRemote function is that it will always return found if the same tag is reused, even if the digests are different.

Information

  • Skaffold version: v2.10.0
  • Operating system: Ubuntu 22.0.3 LTS
  • Installed via: curl -Lo skaffold https://storage.googleapis.com/skaffold/releases/latest/skaffold-linux-amd64

I think this comment may be relevant to the issue.
https://github.com/GoogleContainerTools/skaffold/pull/9211/files#r1447231997

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working priority/p1 High impact feature/bug.
Projects
None yet
2 participants