Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix llvm-cov build #622

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Fix llvm-cov build #622

merged 1 commit into from
Sep 18, 2023

Conversation

ctz
Copy link
Contributor

@ctz ctz commented Sep 18, 2023

Another crack at #620.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #622 (714d51e) into main (6aa8db5) will not change coverage.
The diff coverage is n/a.

❗ Current head 714d51e differs from pull request most recent head d3b55cf. Consider uploading reports for the commit d3b55cf to get more accurate results

@@          Coverage Diff          @@
##            main    #622   +/-   ##
=====================================
  Coverage   98.5%   98.5%           
=====================================
  Files         80      80           
  Lines       9105    9105           
=====================================
  Hits        8968    8968           
  Misses       137     137           
Files Changed Coverage Δ
time/src/lib.rs 100.0% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhpratt
Copy link
Member

jhpratt commented Sep 18, 2023

Could you remove the version bump? I do that at the same time as a release. Otherwise LGTM.

@ctz ctz force-pushed the jbp-fix-llvm-cov-build branch from 714d51e to d3b55cf Compare September 18, 2023 08:40
@ctz
Copy link
Contributor Author

ctz commented Sep 18, 2023

Could you remove the version bump? I do that at the same time as a release. Otherwise LGTM.

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-cleanup Category: cleanup of existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants