Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(lib.rs): renamed no_coverage with coverate_attribute #620

Closed
wants to merge 1 commit into from

Conversation

hitenkoku
Copy link

@hitenkoku hitenkoku commented Sep 16, 2023

Closed #619

What Changed

  • replaced no_coverage with coverage_attribute due to no_coverage

I would appreciate it if you could review when you have time.

@codecov
Copy link

codecov bot commented Sep 16, 2023

Codecov Report

Merging #620 (7fc5f3d) into main (6aa8db5) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #620   +/-   ##
=====================================
  Coverage   98.5%   98.5%           
=====================================
  Files         80      80           
  Lines       9105    9105           
=====================================
  Hits        8968    8968           
  Misses       137     137           
Files Changed Coverage Δ
time/src/lib.rs 100.0% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jhpratt
Copy link
Member

jhpratt commented Sep 17, 2023

A quick search shows that this isn't even used any more. If you'd like to remove the feature gate outright, that would be even better 🙂

@ctz ctz mentioned this pull request Sep 18, 2023
@hitenkoku
Copy link
Author

hitenkoku commented Sep 18, 2023

Thanks for comment.
Sorry for the delay in responding.
This pull reqesst is closed because this pull request is duplicated #622 .

A quick search shows that this isn't even used any more. If you'd like to remove the feature gate outright, that would be even better 🙂

@hitenkoku hitenkoku closed this Sep 18, 2023
@hitenkoku hitenkoku deleted the fix/#619 branch September 18, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errored when execute in cargo llvm-cov
2 participants