-
Notifications
You must be signed in to change notification settings - Fork 728
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: supply a script to update tidb-dashboard #7610
chore: supply a script to update tidb-dashboard #7610
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Hi @baurine. Thanks for your PR. I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7610 +/- ##
==========================================
- Coverage 74.88% 74.78% -0.11%
==========================================
Files 459 459
Lines 50647 50647
==========================================
- Hits 37925 37874 -51
- Misses 9385 9425 +40
- Partials 3337 3348 +11
Flags with carried forward coverage won't be shown. Click here to find out more. |
Signed-off-by: baurine <[email protected]>
63f34da
to
160a6f3
Compare
@@ -0,0 +1,3 @@ | |||
# This file is updated by running scripts/update-dashboard.sh | |||
# Don't edit it manullay | |||
2023.12.18.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tidb-dashboard version will change to x.y.z
(likes 7.6.0
) style in the future, same as TiDB/TiKV/PD.
/ok-to-test |
@mornyx: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 160a6f3
|
@baurine: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7612 Signed-off-by: baurine <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
@baurine: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7612 Signed-off-by: baurine <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
/cherry-pick release-6.5 |
@baurine: new pull request created to branch In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
close tikv#7612 Signed-off-by: baurine <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close tikv#7612 Signed-off-by: baurine <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close tikv#7612 Signed-off-by: baurine <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
close tikv#7612 Signed-off-by: baurine <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
What problem does this PR solve?
Issue Number: Close #7612
What is changed and how does it work?
Because the tidb-dashboard repo may abandon to use
release-version
file to express its version, so we need to adjust the scripts to get tidb-dashbboard version.This PR supplies a new script
scripts/update-dashobard
, when we need to update the tidb-dashobard in PD side, we just need to run the following command:Then commit and push the changes.
That ok, it simplifies the multiple steps before.
This script will persist a dashboard version in a file named
scripts/dashboard-version
, so now we can explicitly know which dashboard version this PD embeds, while we don't know before.This PR also delete the
scripts/embed-dashboard-ui.ps1
andbuild.ps1
files, which I think they are un-used anymore.Release note