-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(build): update Makefile and CI to adjust release mode #1627
Conversation
✅ Deploy Preview for tidb-dashboard canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1627 +/- ##
==========================================
+ Coverage 24.40% 26.37% +1.97%
==========================================
Files 170 97 -73
Lines 15436 10480 -4956
==========================================
- Hits 3767 2764 -1003
+ Misses 11386 7531 -3855
+ Partials 283 185 -98
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report in Codecov by Sentry.
|
e82920b
to
eb69e4f
Compare
not merge this PR before the PD side PR is merged. |
81c0320
to
f7bbcdc
Compare
@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mornyx, shhdgit The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
@baurine: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
New changes are detected. LGTM label has been removed. |
Related PD side PR: tikv/pd#7610
To sync the release mode with the TiDB/TiKV/PD, we abandon to use a unique
release
branch to release all versions, and not userelease-version
file to express the version.