Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update Makefile and CI to adjust release mode #1627

Merged
merged 10 commits into from
Dec 29, 2023

Conversation

baurine
Copy link
Collaborator

@baurine baurine commented Dec 22, 2023

Related PD side PR: tikv/pd#7610

To sync the release mode with the TiDB/TiKV/PD, we abandon to use a unique release branch to release all versions, and not use release-version file to express the version.

@ti-chi-bot ti-chi-bot bot requested a review from Renkai December 22, 2023 10:17
Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for tidb-dashboard canceled.

Name Link
🔨 Latest commit 50e959b
🔍 Latest deploy log https://app.netlify.com/sites/tidb-dashboard/deploys/658e9d955ce74d000820da62

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (17f4b02) 24.40% compared to head (50e959b) 26.37%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1627      +/-   ##
==========================================
+ Coverage   24.40%   26.37%   +1.97%     
==========================================
  Files         170       97      -73     
  Lines       15436    10480    -4956     
==========================================
- Hits         3767     2764    -1003     
+ Misses      11386     7531    -3855     
+ Partials      283      185      -98     
Flag Coverage Δ
backend_integration ?
backend_ut 26.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17f4b02...50e959b. Read the comment docs.

@baurine baurine force-pushed the chore/adjust-release-mode branch from e82920b to eb69e4f Compare December 22, 2023 10:30
@baurine baurine changed the title chore(build): update Makefile and CI chore(build): update Makefile and CI to adjust release mode Dec 22, 2023
@baurine baurine marked this pull request as ready for review December 22, 2023 10:46
@baurine
Copy link
Collaborator Author

baurine commented Dec 22, 2023

@mornyx @shhdgit PTAL, thanks~

@baurine baurine requested review from shhdgit and mornyx December 22, 2023 11:24
@baurine baurine marked this pull request as draft December 22, 2023 11:29
@baurine
Copy link
Collaborator Author

baurine commented Dec 22, 2023

not merge this PR before the PD side PR is merged.

Makefile Outdated Show resolved Hide resolved
@baurine baurine force-pushed the chore/adjust-release-mode branch from 81c0320 to f7bbcdc Compare December 28, 2023 10:12
@baurine baurine marked this pull request as ready for review December 29, 2023 09:56
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

@mornyx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@shhdgit shhdgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@ti-chi-bot ti-chi-bot bot added the lgtm label Dec 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mornyx, shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 29, 2023
@ti-chi-bot ti-chi-bot bot removed the lgtm label Dec 29, 2023
Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-29 10:20:52.574645252 +0000 UTC m=+1820343.611872180: ☑️ agreed by shhdgit.
  • 2023-12-29 10:21:09.910125433 +0000 UTC m=+1820360.947352358: ✖️🔁 reset by ti-chi-bot[bot].

Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

@baurine: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Dec 29, 2023

New changes are detected. LGTM label has been removed.

@baurine baurine merged commit 270f21d into master Dec 29, 2023
14 of 16 checks passed
@baurine baurine deleted the chore/adjust-release-mode branch December 29, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants