Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove git submodules to prevent docs build error #158

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

drwnz
Copy link
Collaborator

@drwnz drwnz commented Jun 2, 2024

PR Type

  • Bug Fix (temporary)

Related Links

Description

An error in git submodule configuration causes the documentation deployment to fail.
This PR removes submodules and adds required repositories to the build.repos file.

Review Procedure

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • (Optional) Unit tests have been written for new behavior
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets

CI Checks

  • Build and test for PR: Required to pass before the merge.

@drwnz drwnz requested a review from mojomex June 2, 2024 00:47
mojomex
mojomex previously approved these changes Jun 2, 2024
@mojomex mojomex self-requested a review June 2, 2024 00:49
@mojomex mojomex dismissed their stale review June 2, 2024 00:50

Missed typo

Copy link
Collaborator

@mojomex mojomex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mojomex mojomex merged commit 6cc19f8 into develop Jun 2, 2024
7 checks passed
@mojomex mojomex deleted the fix/remove_git_submodules branch June 2, 2024 00:52
@mojomex mojomex mentioned this pull request Jul 18, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants