-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(srr520): initial driver #124
Conversation
@mojomex |
nebula_messages/continental_srvs/srv/ContinentalSrr520SetRadarParameters.srv
Outdated
Show resolved
Hide resolved
nebula_common/include/nebula_common/continental/continental_srr520.hpp
Outdated
Show resolved
Hide resolved
nebula_common/include/nebula_common/continental/continental_srr520.hpp
Outdated
Show resolved
Hide resolved
nebula_common/include/nebula_common/continental/continental_srr520.hpp
Outdated
Show resolved
Hide resolved
This PR should be reviewed after #151 is merged |
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…this. need to test with actual hardware Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…iles Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…c driver functionalities with a live sensor Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
…the config file Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
nebula_tests/continental/continental_ros_decoder_test_srr520.hpp
Outdated
Show resolved
Hide resolved
nebula_tests/continental/continental_ros_decoder_test_main_ars548.cpp
Outdated
Show resolved
Hide resolved
nebula_tests/continental/continental_ros_decoder_test_ars548.hpp
Outdated
Show resolved
Hide resolved
nebula_tests/continental/continental_ros_decoder_test_ars548.cpp
Outdated
Show resolved
Hide resolved
nebula_ros/src/continental/continental_srr520_decoder_wrapper.cpp
Outdated
Show resolved
Hide resolved
nebula_ros/src/continental/continental_srr520_hw_interface_wrapper.cpp
Outdated
Show resolved
Hide resolved
nebula_ros/include/nebula_ros/continental/continental_srr520_ros_wrapper.hpp
Outdated
Show resolved
Hide resolved
nebula_ros/include/nebula_ros/continental/continental_srr520_hw_interface_wrapper.hpp
Outdated
Show resolved
Hide resolved
nebula_ros/include/nebula_ros/continental/continental_srr520_decoder_wrapper.hpp
Outdated
Show resolved
Hide resolved
nebula_hw_interfaces/src/nebula_continental_hw_interfaces/continental_srr520_hw_interface.cpp
Outdated
Show resolved
Hide resolved
...de/nebula_hw_interfaces/nebula_hw_interfaces_continental/continental_srr520_hw_interface.hpp
Outdated
Show resolved
Hide resolved
nebula_decoders/src/nebula_decoders_continental/decoders/continental_srr520_decoder.cpp
Outdated
Show resolved
Hide resolved
.../include/nebula_decoders/nebula_decoders_continental/decoders/continental_srr520_decoder.hpp
Outdated
Show resolved
Hide resolved
nebula_common/include/nebula_common/continental/continental_srr520.hpp
Outdated
Show resolved
Hide resolved
nebula_common/include/nebula_common/continental/continental_srr520.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the feedback left above, everything looks good to me!
Co-authored-by: Max Schmeller <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
PR Type
Related Links
Description
Initial hardware interface, decoder, and ros wrappers for the continental SRR520
Review Procedure
Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks