Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tribble incompatible with formattable #785

Closed
odaniel1 opened this issue Jun 7, 2020 · 2 comments
Closed

tribble incompatible with formattable #785

odaniel1 opened this issue Jun 7, 2020 · 2 comments

Comments

@odaniel1
Copy link

odaniel1 commented Jun 7, 2020

Using formattable::formattable() within tribble() fails when there is more than one column.
Perhaps similar to #784?

library(tibble)      # 3.0.1
library(formattable) # 0.2.0.1

# works
tribble(~x, formattable(1.0, 1))
#> # A tibble: 1 x 1
#>   x         
#>   <formttbl>
#> 1  1

# fails
tribble(~x, ~y, 1, formattable(1.0, 1))
#> Error in create_obj(f(remove_class(x, class), ...), class, attr(x, class, : argument "x" is missing, with no default
@krlmlr krlmlr mentioned this issue Jun 12, 2020
Closed
@krlmlr krlmlr closed this as completed in b2d38fe Jun 13, 2020
@krlmlr
Copy link
Member

krlmlr commented Jun 14, 2020

Thanks for reporting!

krlmlr added a commit that referenced this issue Feb 25, 2021
@krlmlr
Merge tag 'v3.0.2' into f-invariants
7fff63b 
tibble 3.0.2

- `[[` works with classed indexes again, e.g. created with `glue::glue()` (#778).
- `add_column()` works without warning for 0-column data frames (#786).
- `tribble()` now better handles named inputs (#775) and objects of non-vtrs classes like `lubridate::Period` (#784) and `formattable::formattable` (#785).

- Subsetting and subassignment are faster (#780, #790, #794).
- `is.null()` is preferred over `is_null()` for speed.
- Implement continuous benchmarking (#793).

- `is_vector_s3()` is no longer reexported from pillar (#789).
@github-actions
Copy link
Contributor

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.

@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@krlmlr @odaniel1