Referencing column with [[ ]] fails when column name is created from glue

[dturkenk]

Newly upgraded to tibble 3.0.1 and referencing a column using [[ ]] no longer seems to work if the column name is created using glue::glue.

Casting the return as a character seems to work ok.

library(tibble)
#> Warning: package 'tibble' was built under R version 3.6.3
df <- tribble(~a, ~b, "foo", 3)
lbl <- "c"
df[[glue::glue("{lbl}")]] <- "bar"
#> Error: Can't assign to columns that don't exist.
#> x Column `c` doesn't exist.
df[[as.character(glue::glue("{lbl}"))]] <- "bar"

[dturkenk]

An additional note, using glue::glue to reference a column that already exists seems to work fine as well.

[hadley]

Slightly more minimal reprex:

library(tibble)
#> Warning: package 'tibble' was built under R version 3.6.2
df <- tibble(a = 1, b = 2)
df[[glue::glue("c")]]
#> NULL
df[[glue::glue("c")]] <- "bar"
#> Error: Can't assign to columns that don't exist.
#> x Column `c` doesn't exist.

^{Created on 2020-06-05 by the reprex package (v0.3.0)}

[krlmlr]

This should be solved upstream, otherwise we'll end up replicating lots of vctrs logic here:

library(vctrs)

vec_as_location(glue::glue("a"), 26, letters)
#> [1] 1
vec_as_location2(glue::glue("a"), 26, letters)
#> [1] 1

foo <- function(x) {
  structure(x, class = "foo")
}

vec_as_location(foo("a"), 26, letters)
#> Error: Must subset elements with a valid subscript vector.
#> x Subscript has the wrong type `foo`.
#> ℹ It must be logical, numeric, or character.
vec_as_location2(foo("a"), 26, letters)
#> Error: Must extract element with a single valid subscript.
#> x Subscript has the wrong type `foo`.
#> ℹ It must be numeric or character.

^{Created on 2020-07-05 by the reprex package (v0.3.0)}

[krlmlr]

On the other hand, we can use vec_as_subscript() to be more consistent here.

[krlmlr]

Now:

library(tibble)

df <- tibble(a = 1, b = 2)
df[[glue::glue("c")]]
#> NULL
df[[glue::glue("c")]] <- "bar"
df
#> # A tibble: 1 x 3
#>       a     b c    
#>   <dbl> <dbl> <chr>
#> 1     1     2 bar

^{Created on 2020-07-06 by the reprex package (v0.3.0)}

[github-actions]

This old thread has been automatically locked. If you think you have found something related to this, please open a new issue and link to this old issue if necessary.