Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move .censoring weights graf.workflow #213

Merged
merged 7 commits into from
Dec 13, 2023
Merged

Move .censoring weights graf.workflow #213

merged 7 commits into from
Dec 13, 2023

Conversation

EmilHvitfeldt
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt mentioned this pull request Dec 12, 2023
Merged
hfrick
hfrick approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@hfrick hfrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but I think we still need to import the generic from parsnip here

@hfrick
Copy link
Member

hfrick commented Dec 13, 2023

I've opened #214 to address the failing test re (Intercept) so let's update from main once that is resolved and check the GHA results again before merging this one.

simonpcouch
simonpcouch approved these changes Dec 13, 2023
View reviewed changes
Copy link
Contributor

@simonpcouch simonpcouch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm on board with registering normally here in favor of conditionally s3_register()ing—that conflict should only exist briefly on CRAN. :)

simonpcouch
simonpcouch reviewed Dec 13, 2023
View reviewed changes
DESCRIPTION Outdated Show resolved Hide resolved
@EmilHvitfeldt EmilHvitfeldt merged commit b841ff0 into main Dec 13, 2023
10 checks passed
@EmilHvitfeldt EmilHvitfeldt deleted the move-.censoring_weights_graf.workflow branch December 13, 2023 21:13
hfrick added a commit to tidymodels/extratests that referenced this pull request Dec 15, 2023
@hfrick
add skip for method moved to workflows
aebee37 
tidymodels/parsnip#1038 and tidymodels/workflows#213
@hfrick hfrick mentioned this pull request Dec 15, 2023
Merged
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simonpcouch simonpcouch simonpcouch approved these changes

@hfrick hfrick hfrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@EmilHvitfeldt @hfrick @simonpcouch