Move .censoring weights graf.workflow #1038
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to close #968
Paired {workflows} PR: tidymodels/workflows#213
There are 4 possible scenarios:
.censoring_weights_graf.workflow()
is exported from only {parsnip}This is fine!
Happens if
parsnip < 1.1.1.9007
andworkflows < 1.1.3.9001
, which is another way of saying that both packages are installed before Dec 12..censoring_weights_graf.workflow()
is exported from only {workflows}This is fine!
Happens if
parsnip >= 1.1.1.9007
andworkflows >= 1.1.3.9001
, which is another way of saying that both packages are installed after Dec 12 (or whenever the PRs are merged in..censoring_weights_graf.workflow()
is exported from both {parsnip} and {workflows}This is not good.
Would need
parsnip < 1.1.1.9007
andworkflows >= 1.1.3.9001
. Which can't happen as workflows1.1.3.9001
requiresparsnip >= 1.1.1.9007
. So we are good here.##
.censoring_weights_graf.workflow()
isn't exportedWould happen if
parsnip >= 1.1.1.9007
andworkflow < 1.1.3.9001
. Which could happen. I can't recall if there is a way for us to deal with this last point