-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored functions to evaluate/check metric and eval time arguments #780
Conversation
Co-authored-by: Hannah Frick <[email protected]>
Co-authored-by: Hannah Frick <[email protected]>
Co-authored-by: Hannah Frick <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of questions about future directions, collected from the comments:
- what is the plan for for
check_metrics()
vscheck_metrics_arg()
andcheck_eval_time()
vscheck_eval_time_arg()
? - are we still aiming to remove tune's dependency on censored?
- we could include parsnip's
.filter_eval_time()
in the standalone file for survival utilities .get_metric_time()
is now unused - let's remove/deprecate it?
A consistency comment
- warn instead of error on <2 time points for integrated survival metric?
An oversight
- the snapshot test for
last_fit
needs to be properly updated
Co-authored-by: Hannah Frick <[email protected]>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
This includes reworked versions of the argument checking code used by a family of functions:
fit_resamples()
,tune_*()
, andlast_fit()
.I've wholesale copied
parsnip::.filter_eval_time
to use here; we should probably export that.For testing
tune_bayes()
, we'll need an additional engine so that will have to go into extratests.An updated itinerary of PRs
tune_*
functions,fit_resamples()
. etc.autoplot()
)