-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor choose_metric #777
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! I've added some suggestions on error handling and cli styling since we're already at it.
Co-authored-by: Hannah Frick <[email protected]>
This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue (with a reprex: https://reprex.tidyverse.org) and link to this issue. |
Uses new code from #768. This only changes the metric code; evaluation times will be the next PR.
Generally, the error messages are improved:
old: (error) "Please check the value of
metric
.new (warn): "'WAT' was not in the metric set. Please choose from: 'rmse', 'rsq'"
old (error) "Please specify a single character value for
metric
."new (warn) "2 metrics were given; 'rmse' will be used"
This PR also gets rid of the old checks from the second version of tune: "The
maximize
argument is no longer needed."Updated PR sequence:
show_best()
andselect_best()
.show_best()
andselect_best()
(see When we need to default to a single value foreval_time
#766).autoplot()
)tune_*
functions,fit_resamples()
. etc.