Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test last_fit() for survival models #142

Merged
merged 21 commits into from
Dec 18, 2023
Merged

Test last_fit() for survival models #142

merged 21 commits into from
Dec 18, 2023

Conversation

topepo
Copy link
Member

@topepo topepo commented Nov 16, 2023

Closes #114

Change included from previous grid testing

@topepo topepo marked this pull request as ready for review November 16, 2023 16:29
@topepo topepo requested a review from EmilHvitfeldt November 16, 2023 16:29
Copy link
Member

@EmilHvitfeldt EmilHvitfeldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, very clean. runs fast 🐎

tests/testthat/test-survival-last-fit.R Outdated Show resolved Hide resolved
tests/testthat/test-survival-last-fit.R Outdated Show resolved Hide resolved
tests/testthat/test-survival-last-fit.R Outdated Show resolved Hide resolved
tests/testthat/test-survival-last-fit.R Outdated Show resolved Hide resolved
tests/testthat/test-survival-last-fit.R Outdated Show resolved Hide resolved
tests/testthat/test-survival-last-fit.R Outdated Show resolved Hide resolved
topepo and others added 2 commits December 17, 2023 20:59
@topepo topepo merged commit 1c35f59 into main Dec 18, 2023
5 checks passed
@topepo topepo deleted the issue-114 branch December 18, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test last_fit() for survival models
2 participants