Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test fit_resamples() for survival models #113

Closed
hfrick opened this issue Nov 9, 2023 · 0 comments · Fixed by #141
Closed

Test fit_resamples() for survival models #113

hfrick opened this issue Nov 9, 2023 · 0 comments · Fixed by #141
Assignees

Comments

@hfrick
Copy link
Member

hfrick commented Nov 9, 2023

What we already have: nothing for survival models

What we still want: something that emulates what we are doing for tuning (since this is a subset of our tuning methods).

I've added a template in the work for #117 since it will be easier for reviewers to do both at once.

@topepo topepo self-assigned this Nov 13, 2023
topepo added a commit that referenced this issue Nov 13, 2023
topepo added a commit that referenced this issue Nov 16, 2023
* initial changes

* test for Bayesian optimization

* move grid testing to use glmnet

* reorganize/block code

* add more tests

* move to mboost as model

* update SA metric collection and other tests

* update to race with rpart trees

* Added tests for #113

* remaining racing results

* last_fit tests for survival models

* smaller, more portable file names

* remove other files

* updates from reviewer feedback

* Apply suggestions from code review

Co-authored-by: Emil Hvitfeldt <[email protected]>

* "Emil's banner format"

---------

Co-authored-by: Emil Hvitfeldt <[email protected]>
topepo added a commit that referenced this issue Nov 16, 2023
* initial changes

* test for Bayesian optimization

* move grid testing to use glmnet

* reorganize/block code

* add more tests

* move to mboost as model

* update SA metric collection and other tests

* update to race with rpart trees

* Added tests for #113

* partial collect metric tests

* remaining racing results

* last_fit tests for survival models

* smaller, more portable file names

* changes based on reviewer comments

* remove last_fit tests
topepo added a commit that referenced this issue Dec 18, 2023
* initial changes

* test for Bayesian optimization

* move grid testing to use glmnet

* reorganize/block code

* add more tests

* move to mboost as model

* update SA metric collection and other tests

* update to race with rpart trees

* Added tests for #113

* partial collect metric tests

* remaining racing results

* last_fit tests for survival models

* smaller, more portable file names

* changes based on reviewer comments

* remove fit_resamples tests

* Apply suggestions from code review

Co-authored-by: Emil Hvitfeldt <[email protected]>

* Apply suggestions from code review

Co-authored-by: Emil Hvitfeldt <[email protected]>

---------

Co-authored-by: Emil Hvitfeldt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants