EdkRepo: Fix incorrect manifest change calculations #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinsun49
approved these changes
Mar 14, 2023
In the sync -u flow only the repository defining characteristics of a repo_source tuple should be used to determine whether the initial and new source are the same. This change ensures that only the remote name, url and local root are compared. Fixes tianocore#135 Signed-off-by: Ashley E Desimone <[email protected]> Reviewed-by: Kevin Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the sync -u flow only the repository defining characteristics of a repo_source tuple should be used to determine whether the initial and new source are the same. This change ensures that only the remote name, url and local root are compared.
Fixes #135