Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only flag a repo source as different when key identifiers do not match #135

Closed
ashedesimone opened this issue Feb 28, 2023 · 0 comments · Fixed by #136
Closed

Only flag a repo source as different when key identifiers do not match #135

ashedesimone opened this issue Feb 28, 2023 · 0 comments · Fixed by #136
Assignees
@ashedesimone
Labels
bug Something isn't working

Comments

@ashedesimone
Copy link
Contributor

ashedesimone commented Feb 28, 2023 •
edited
Loading

In the sync -u flow the repo source tuples for the initial and new sources are compared. Items that are acceptable to change such as branch, sparse checkout status, etc... are used in this calculation causing the source to be erroneously identified as different and raising a manifest changed exception
@ashedesimone ashedesimone added the bug Something isn't working label Feb 28, 2023
@ashedesimone ashedesimone self-assigned this Feb 28, 2023
ashedesimone added a commit to ashedesimone/edk2-edkrepo that referenced this issue Feb 28, 2023
@ashedesimone
EdkRepo: Fix incorrect manifest change calculations
7590f76 
In the sync -u flow only the repository defining characteristics
of a repo_source tuple should be used to determine whether the
initial and new source are the same. This change ensures that
only the remote name, url and local root are compared.

Fixes tianocore#135

Signed-off-by: Ashley E Desimone <[email protected]>
@ashedesimone ashedesimone mentioned this issue Feb 28, 2023
Merged
ashedesimone added a commit to ashedesimone/edk2-edkrepo that referenced this issue Mar 14, 2023
@ashedesimone
EdkRepo: Fix incorrect manifest change calculations
2835379 
In the sync -u flow only the repository defining characteristics
of a repo_source tuple should be used to determine whether the
initial and new source are the same. This change ensures that
only the remote name, url and local root are compared.

Fixes tianocore#135

Signed-off-by: Ashley E Desimone <[email protected]>
Reviewed-by: Kevin Sun <[email protected]>
ashedesimone added a commit that referenced this issue Mar 14, 2023
@ashedesimone
EdkRepo: Fix incorrect manifest change calculations
7975b7f 
In the sync -u flow only the repository defining characteristics
of a repo_source tuple should be used to determine whether the
initial and new source are the same. This change ensures that
only the remote name, url and local root are compared.

Fixes #135

Signed-off-by: Ashley E Desimone <[email protected]>
Reviewed-by: Kevin Sun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ashedesimone ashedesimone

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

EdkRepo: Fix incorrect manifest change calculations ashedesimone/edk2-edkrepo
1 participant
@ashedesimone