Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Spotless #7328

Merged
merged 5 commits into from
Nov 7, 2023
Merged

Update Spotless #7328

merged 5 commits into from
Nov 7, 2023

Conversation

wmontwe
Copy link
Member

@wmontwe wmontwe commented Nov 7, 2023

Bump Spotless 6.21.0 -> 6.22.0

Fixed yml style and enforce max line length of 120.

@wmontwe wmontwe requested a review from cketti November 7, 2023 09:55
@wmontwe wmontwe mentioned this pull request Nov 7, 2023
Comment on lines +22 to +25
val seed = IntRange(0, 28).toList().toIntArray()

val random = createRandom(*seed, 35)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note (for future changes): I think it's useful when tests are separated into arrange, act, assert blocks. Most of the time this separation can be easily achieved by using an empty line between the blocks. By introducing additional empty lines, this change makes it somewhat harder to figure out at a glance which lines belong to which block.

@wmontwe wmontwe merged commit 19a14fe into main Nov 7, 2023
3 checks passed
@wmontwe wmontwe deleted the update_spotless branch November 7, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants