-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update code style #7312
Update code style #7312
Conversation
…se Rules 0.1.11 -> 0.3.2 and Ktlint 0.50.0 -> 1.0.1
…down files and enforce max line length of 120 globally
…amount of style changes
…ed by ktlint 1.0.1
…heme for @Preview annotations This is no validated by the compose detekt plugin.
Did you use spotlessApply to reformat the code? Some lines that don't exceed 120 characters have been reformatted. Maybe there's a bug in there somewhere? |
The There have been some cases where it complained about When I was running |
This updates Spotless 6.21.0 -> 6.22.0, Detekt 1.23.0 -> 1.23.3, Detekt Compose Rules 0.1.11 -> 0.3.2 and ktlint 0.50.0 -> 1.0.1.
Unfortunatelly ktlint from version 1.0.0 introduced breaking changes by switching from
intellij_idea
toktlint_official
as default code style and enabling a set of new rules by default. Some of the rules are not very compatible with our project and how Android Studio is able to format code. The problematic rules have been disabled for now.The configuration has been altered to reduce the ammount of changes. But as the updated ktlint now properly checks for
max_line_length
some changes to previously missed code had to be done.DevicePreviews
have been renamed toPreviewDevices
to follow Google's naming convention for@Preview
annotations.Depends on: #7311