Revert to strings.Title again for pascalCase #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-hang
force-pushed
the
rhang/reuse-strings-title
branch
3 times, most recently
from
cd2d438 to
46b1492
Compare
sywhang
approved these changes
Jun 9, 2023
Codecov Report
@@ Coverage Diff @@
## dev #582 +/- ##
=======================================
Coverage 68.01% 68.01%
=======================================
Files 142 142
Lines 23878 23878
=======================================
Hits 16241 16241
Misses 4577 4577
Partials 3060 3060
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
PR #578 replaced strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added. Example: ``` chunk := "10x" fmt.Println(strings.Title(strings.ToLower(chunk))) # 10x fmt.Println(cases.Title(language.English).String(strings.ToLower(chunk))) # 10X ```
r-hang
force-pushed
the
rhang/reuse-strings-title
branch
from
2155616 to
495fa70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #578 replaced strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing.
A test case to flag this change and an exemption for staticcheck in the relevant file are also added.
Example: