Fix remaining lint errors #578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sywhang
approved these changes
May 30, 2023
Codecov Report
@@ Coverage Diff @@
## dev #578 +/- ##
=======================================
Coverage 68.00% 68.00%
=======================================
Files 140 140
Lines 23872 23872
=======================================
Hits 16233 16233
Misses 4578 4578
Partials 3061 3061
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After rebasing #574 on top of #577 and running GO111MODULE=on make lint I still see some errors. cmd/thriftbreak/main_test.go:26:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019) gen/string.go:66:15: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019) After this change: $ git log --oneline a054ce6 (HEAD -> optimise_read_string) Fix remaining lint errors 2c1d285 build tags 8a1aa7d address review comments f26170a inline 41dacbd remove bench reports 4ad4d9c optimise write string fb22d6e optimise readstring() 6268dfe (origin/dev, origin/HEAD) Remove all usages of io/ioutil (#577) $ GO111MODULE=on make lint Checking gofmt Checking govet Checking golint Checking staticcheck $ echo $? 0
r-hang
force-pushed
the
rhang/fix-remaining-lint
branch
from
86d21fa to
c7a5992
Compare
r-hang
added a commit
that referenced
this pull request
Jun 9, 2023
PR #578 replace strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added.
r-hang
added a commit
that referenced
this pull request
Jun 9, 2023
PR #578 replace strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added. Example: chunk := "10x" fmt.Println(strings.Title(strings.ToLower(chunk))) # 10x fmt.Println(cases.Title(language.English).String(strings.ToLower(chunk))) # 10X
r-hang
added a commit
that referenced
this pull request
Jun 9, 2023
PR #578 replace strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added. Example: ``` chunk := "10x" fmt.Println(strings.Title(strings.ToLower(chunk))) # 10x fmt.Println(cases.Title(language.English).String(strings.ToLower(chunk))) # 10X ```
r-hang
added a commit
that referenced
this pull request
Jun 9, 2023
PR #578 replaced strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added. Example: ``` chunk := "10x" fmt.Println(strings.Title(strings.ToLower(chunk))) # 10x fmt.Println(cases.Title(language.English).String(strings.ToLower(chunk))) # 10X ```
r-hang
added a commit
that referenced
this pull request
Jun 9, 2023
PR #578 replaced strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added. Example: ``` chunk := "10x" fmt.Println(strings.Title(strings.ToLower(chunk))) # 10x fmt.Println(cases.Title(language.English).String(strings.ToLower(chunk))) # 10X ```
r-hang
added a commit
that referenced
this pull request
Jun 9, 2023
PR #578 replaced strings.Title with golang.org/x/text/cases due to staticcheck SA1019. There is at least one behavioral difference between these two Title casing approaches uncovered during pre-release testing. A test case to flag this change and an exemption for staticcheck in the relevant file are also added. Example: ``` chunk := "10x" fmt.Println(strings.Title(strings.ToLower(chunk))) # 10x fmt.Println(cases.Title(language.English).String(strings.ToLower(chunk))) # 10X ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After rebasing #574 on top of #577 and running GO111MODULE=on make lint I still see some errors.
cmd/thriftbreak/main_test.go:26:2: "io/ioutil" has been deprecated since Go 1.19: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)
gen/string.go:66:15: strings.Title has been deprecated since Go 1.18 and an alternative has been available since Go 1.0: The rule Title uses for word boundaries does not handle Unicode punctuation properly. Use golang.org/x/text/cases instead. (SA1019)
After this change:
$ git log --oneline
a054ce6 (HEAD -> optimise_read_string) Fix remaining lint errors
2c1d285 build tags
8a1aa7d address review comments
f26170a inline
41dacbd remove bench reports
4ad4d9c optimise write string
fb22d6e optimise readstring()
6268dfe (origin/dev, origin/HEAD) Remove all usages of io/ioutil (#577)
$ GO111MODULE=on make lint
Checking gofmt
Checking govet
Checking golint
Checking staticcheck
$ echo $?
0
I've cherry-picked the contents of the HEAD commit displayed above into a separate branch for a PR to dev.