UI: Initiate Minting step #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `LabeledBadge` component will be reused in the future. Additional changes: adjusted spacings.
Moved ModalHeader rendering to higher order component with additional label parameter. Restyled Spinner component. Added onError callback when deposit transaction is failed with storing error data (entry point for Toast component rendering).
Copied from Treshold Dashboard
Restyled component, added variable orientation and position, added optional collapsible details, improved responsive behavior.
Closed
michalsmiarowski
requested changes
Feb 13, 2024
There was a problem hiding this comment.
Left some comments to look at. It looks like lot of the code is copier from token-dashboard when we've already done a review. Some of the code was also cherry-picked in #21 where I've also done a review 😉
I would love to test it out once we merge other PRs
Merged
`withTotal` => `withTotalFees` `withSubTotal` => `withSubtotalFees`
kpyszkowski
commented
Feb 13, 2024
This commit reverts changes lost after main branch merge.
michalsmiarowski
requested changes
Feb 19, 2024
The `onPreviousStepClick` prop, if given, conditionally renders previous step button.
It's incorrect to wrap general-purpose elements like `div` with semantically meaningful elements like `p`. This commit resolves the issue morphing `p` into `div`.
Refactored styles to be defined as chakra theme. Replaced boolean style props with variant prop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5
Depends on: #12
This pull request introduces redesigned Initiate Minting minting flow step.
Additional changes:
Toastcomponent with collapsible details, adjustable position and orientation:Position: center, expanded and collapsed details
Position: left
Position: right
LabeledBadgecomponent