UI: Make Deposit step #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added setTimeout utility function
Applied minor styling corrections
Fixed QR code size and spacing, address text color, uncommented code line
This commit is cherry picked from the `ui/initiate-minting-step` branch for consistency between changes. Moved ModalHeader rendering to higher order component with additional label parameter. Restyled Spinner component. Added onError callback when deposit transaction is failed with storing error data (entry point for Toast component rendering).
`Toast` component will be introduced with `ui/initiate-minting-step` branch. It's reverted from this branch. This reverts commit b14b805.
This reverts commit 4b10dd5.
Closed
michalsmiarowski
requested changes
Feb 12, 2024
| </BodyMd> | ||
| </VStack> | ||
| <Flex as={Badge} align="center"> | ||
| {/* TODO: Adjust styles when Badge changes are merged. */} |
There was a problem hiding this comment.
Can you tell me in wchich PR the Badge changes are addressed?
There was a problem hiding this comment.
Actually it's LabeledBadge introduced in this PR.
I will complete this TODO in separate PR.
There was a problem hiding this comment.
Ok, I will leave this conversation open then
kpyszkowski
commented
Feb 13, 2024
| </BodyMd> | ||
| </VStack> | ||
| <Flex as={Badge} align="center"> | ||
| {/* TODO: Adjust styles when Badge changes are merged. */} |
There was a problem hiding this comment.
Actually it's LabeledBadge introduced in this PR.
I will complete this TODO in separate PR.
michalsmiarowski
requested changes
Feb 19, 2024
michalsmiarowski
requested changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #4
Depends on: #12This pull request introduces redesigned Make Deposit minting flow step.
Additional changes:
GenerateNewDepositAddressmodal redesign:Note: Changes currently doesn't fulfill designs requirements completely. It requires additional finetunes after #20 is merged - can be done with separate PR