Show group members in header #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added: filter to transform ID-array to (display-)name array; Show group members in header (truncate not working atm)
…ones/threema-web into threema-web-6
Changed: used the existing class for styling
dbrgn
suggested changes
Mar 8, 2017
src/filters.ts
Outdated
| /** | ||
| * Convert ID-Array to (Display-)Name-String, separated by ',' | ||
| */ | ||
| .filter('idToName', ['WebClientService', function (webClientService: threema.WebClientService) { |
There was a problem hiding this comment.
The .filter call should not be indented, to match the rest of the file.
Also, the function should probably be named idsToNames, since it accepts multiple ids.
dbrgn
suggested changes
Mar 8, 2017
| overflow: hidden; | ||
| text-overflow: ellipsis; | ||
| max-width: 100%; | ||
| display: inherit; |
There was a problem hiding this comment.
Can you add line-height: 1.3 here? Otherwise text containing characters like "g" is cut off at the bottom.
sillych
reviewed
Mar 8, 2017
| @@ -20,6 +20,9 @@ | |||
| <eee-verification-level ng-if="ctrl.type == 'contact'" | |||
| contact="ctrl.receiver"></eee-verification-level> | |||
| </div> | |||
| <div class="conversation-header-details-detail" ng-if="ctrl.type == 'group'"> | |||
There was a problem hiding this comment.
please add the whole list to the title attribute
title="{{ctrl.receiver.members | idToName}}"
dbrgn
approved these changes
Mar 8, 2017
|
Thanks! |
IndianaDschones
added a commit
to IndianaDschones/threema-web
that referenced
this pull request
Mar 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6