Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show group members in header #6

Closed
dbrgn opened this issue Feb 15, 2017 · 6 comments
Closed

Show group members in header #6

dbrgn opened this issue Feb 15, 2017 · 6 comments
Labels
enhancement Enhances functionality good first issue If you want to get your hands dirty, this is a good start! ui User interface related

Comments

@dbrgn
Copy link
Contributor

dbrgn commented Feb 15, 2017

Show group members in header, below group name (similar to app).
@dbrgn dbrgn added good first issue If you want to get your hands dirty, this is a good start! enhancement Enhances functionality ui User interface related labels Feb 15, 2017
@IndianaDschones
Copy link
Contributor

I´d like to solve this issue.

@dbrgn
Copy link
Contributor Author

dbrgn commented Mar 7, 2017

@IndianaDschones 👍 go for it :)

@IndianaDschones
Copy link
Contributor

@dbrgn It works but the group members string does not truncate. I added the necessary css properties
.group-members { white-space: nowrap; overflow: hidden; text-overflow: ellipsis; } but the text just ends instead of showing ellipsis.
notruncate

Do you have an idea?

@sillych
Copy link
Contributor

sillych commented Mar 8, 2017

@IndianaDschones did you try the max-width: property on the group-members element?

@IndianaDschones
Copy link
Contributor

IndianaDschones commented Mar 8, 2017 •
edited
Loading

@sillych The max-width: property works if i also add display: inline-block to group-members.

Edit 1
max-widt: 100% on group-members and changing the max-width of the header-details-div makes the text truncate correctly.

@IndianaDschones
Copy link
Contributor

@sillych I finally fixed it 🎉
I added overflow: hidden to the header-details element. Creating a PR in a few.

@IndianaDschones IndianaDschones mentioned this issue Mar 8, 2017
Merged
@dbrgn dbrgn closed this as completed in #145 Mar 8, 2017
dbrgn pushed a commit that referenced this issue Mar 8, 2017
@IndianaDschones @dbrgn
Show group members in header (#145)
f03b59f 
Fixes #6
IndianaDschones added a commit to IndianaDschones/threema-web that referenced this issue Mar 9, 2017
@IndianaDschones
Show group members in header (threema-ch#145)
9ceb97f 
Fixes threema-ch#6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhances functionality good first issue If you want to get your hands dirty, this is a good start! ui User interface related
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dbrgn @sillych @IndianaDschones