Silence Puma's startup messages in JS specs #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabebw
commented
Jun 19, 2019
| @@ -8,8 +8,12 @@ def add_gems | |||
| Bundler.with_clean_env { run "bundle install" } | |||
| end | |||
|
|
|||
| def configure_chromedriver | |||
| def configure_capybara | |||
There was a problem hiding this comment.
I thought this new name made more sense, but I'm happy to revert this change.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| copy_file "chromedriver.rb", "spec/support/chromedriver.rb" | ||
| copy_file( | ||
| "capybara_silence_puma.rb", | ||
| "spec/support/capybara_silence_puma.rb" |
There was a problem hiding this comment.
Style/TrailingCommaInArguments: Put a comma after the last parameter of a multiline method call.
When Capybara starts the first JavaScript spec of a run, it starts Puma
and prints out the Puma startup messages:
Capybara starting Puma...
* Version 3.12.1 , codename: Llamas in Pajamas
* Min threads: 0, max threads: 4
* Listening on tcp://127.0.0.1:62516
By setting `Silent: true`, we can prevent those messages from being
printed.
A bit of background: rspec/rspec-rails#1897
Proof that Capybara uses Puma as its default server: https://github.com/teamcapybara/capybara/blob/3.24.0/lib/capybara.rb#L247-L249
gabebw
force-pushed
the
gbw-silence-puma-startup-messages-in-JS-specs
branch
from
a217a57 to
368ca7f
Compare
|
I like it! |
cpjmcquillan
added a commit
to cpjmcquillan/suspenders
that referenced
this pull request
May 18, 2023
Capybara was configured to silence Puma in thoughtbot#981 to prevent Puma startup messages being output when running specs with `js: true`. This configuration has since been updated in [rspec-rails](rspec/rspec-rails#2289), so we can remove it here.
stevepolitodesign
pushed a commit
that referenced
this pull request
May 27, 2023
Capybara was configured to silence Puma in #981 to prevent Puma startup messages being output when running specs with `js: true`. This configuration has since been updated in [rspec-rails](rspec/rspec-rails#2289), so we can remove it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Capybara starts the first JavaScript spec of a run, it starts Puma
and prints out the Puma startup messages:
By setting
Silent: true, we can prevent those messages from being printed.A bit of background: rspec/rspec-rails#1897
Proof that Capybara uses Puma as its default server: https://github.com/teamcapybara/capybara/blob/3.24.0/lib/capybara.rb#L247-L249