Make puma log silence completely #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid:
1) Widget management enables me to create widgets
Failure/Error: raise ActionController::RoutingError, "No route matches [#{env['REQUEST_METHOD']}] #{env['PATH_INFO'].inspect}"
ActionController::RoutingError:
No route matches [GET] "/stylesheets/application.css"
benoittgt
commented
Mar 16, 2020
| @@ -197,12 +198,13 @@ namespace :no_active_record do | |||
| sh "bundle binstubs railties" unless File.exist?("bin/rails") | |||
|
|
|||
| application_file = File.read("config/application.rb") | |||
| application_file.gsub!("config.assets.enabled = true", "config.assets.enabled = false") | |||
| application_file.gsub!('# require "sprockets/railtie"', 'require "sprockets/railtie"') | |||
There was a problem hiding this comment.
I felt quite dirty to do this.
benoittgt
requested review from
JonRowe and
pirj
and removed request for
JonRowe
benoittgt
commented
Mar 16, 2020
Changelog.md
Outdated
| @@ -7,6 +7,7 @@ Enhancements: | |||
| * The scaffold generator now generates request specs in preference to controller specs. | |||
| (Luka Lüdicke, #2288) | |||
| * Add configuration option to disable ActiveRecord. (Jon Rowe, Phil Pirozhkov, Hermann Mayer, #2266) | |||
| * Remove Puma log when running system specs. (ta1kt0me, Benoit Tigeot, #2011) | |||
There was a problem hiding this comment.
Should I reference this one?
JonRowe
approved these changes
Mar 17, 2020
JonRowe
reviewed
Mar 17, 2020
Co-Authored-By: Jon Rowe <[email protected]>
JonRowe
added a commit
that referenced
this pull request
Mar 24, 2020
Co-Authored-By: Jon Rowe <[email protected]>
JonRowe
added a commit
that referenced
this pull request
Mar 24, 2020
8 tasks
tagliala
added a commit
to diowa/ruby3-rails6-bootstrap-heroku
that referenced
this pull request
Aug 19, 2021
Fixed in version 4.0.0 of rspec-rails by rspec/rspec-rails#2289
cpjmcquillan
added a commit
to cpjmcquillan/suspenders
that referenced
this pull request
May 18, 2023
Capybara was configured to silence Puma in thoughtbot#981 to prevent Puma startup messages being output when running specs with `js: true`. This configuration has since been updated in [rspec-rails](rspec/rspec-rails#2289), so we can remove it here.
stevepolitodesign
pushed a commit
to thoughtbot/suspenders
that referenced
this pull request
May 27, 2023
Capybara was configured to silence Puma in #981 to prevent Puma startup messages being output when running specs with `js: true`. This configuration has since been updated in [rspec-rails](rspec/rspec-rails#2289), so we can remove it here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue #2011