Remove the with qualifier on define_enum_for matcher #1589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matsales28
reviewed
Dec 19, 2023
amalrik
force-pushed
the
remove-with-qualifier
branch
from
f42a07d to
b35c91d
Compare
|
@matsales28 done :) |
|
Hello @amalrik, it's been a while! I hope you are doing great. Oh, I had forgotten about this issue. I genuinely appreciate your contribution! The error on the CI is related to an intermittent test. Fortunately, @matsales28 has proposed a solution for it. Once he merges his pull request, we can resume the CI to verify the changes. Thank you! |
matsales28
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1462