Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the with qualifier on define_enum_for matcher #1462

Closed
vsppedro opened this issue Oct 1, 2021 · 0 comments · Fixed by #1589
Closed

Remove the with qualifier on define_enum_for matcher #1462

vsppedro opened this issue Oct 1, 2021 · 0 comments · Fixed by #1589
Assignees
@vsppedro

Comments

@vsppedro
Copy link
Collaborator

vsppedro commented Oct 1, 2021 •
edited
Loading

I'm creating this issue as a reminder to remove this deprecated method.

shoulda-matchers/lib/shoulda/matchers/active_record/define_enum_for_matcher.rb

Lines 206 to 212 in 3e9d69b

def with(expected_enum_values)
Shoulda::Matchers.warn_about_deprecated_method(
'The `with` qualifier on `define_enum_for`',
'`with_values`',
)
with_values(expected_enum_values)
end

@vsppedro vsppedro self-assigned this Oct 1, 2021
amalrik added a commit to amalrik/shoulda-matchers that referenced this issue Dec 19, 2023
@amalrik
closes thoughtbot#1462 - Remove the with qualifier on define_enum_for…
f42a07d 
… matcher
@amalrik amalrik mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsppedro vsppedro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove the with qualifier on define_enum_for matcher amalrik/shoulda-matchers
1 participant
@vsppedro