This repository has been archived by the owner on May 31, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
[WIP] Finish the character creation wizard #62
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
thislooksfun
commented
Oct 6, 2019
•
edited
Loading
edited
- Basic info
- Attribute points
- Talents
- Talent options
- Spells
- Knowledge skill(s)
- Artisan skill
- Skill ranks
- Equipment
- Fleshing out character
thislooksfun
changed the title
Finish the character creation wizard
[WIP] Finish the character creation wizard
Oct 6, 2019
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
=========================================
- Coverage 29.85% 22.5% -7.36%
=========================================
Files 44 49 +5
Lines 412 600 +188
Branches 20 46 +26
=========================================
+ Hits 123 135 +12
- Misses 289 465 +176
Continue to review full report at Codecov.
|
thislooksfun
force-pushed
the
feature/finish-wizard
branch
from
October 18, 2019 02:02
f0145d6
to
c420c01
Compare
Make the effect actually cause an effect when cast on self.earthdawn/src/assets/earthdawn/spells/__template__.yml Lines 7 to 12 in ab1e64d
This comment was generated by todo based on a
|
Split into helper functionThis code pattern is repeated several times in the different asset loaders. It should probably be broken out into a helper function. earthdawn/src/assets/earthdawn/spells/index.js Lines 6 to 11 in ab1e64d
This comment was generated by todo based on a
|
github-actions
bot
added
assets
Changes to static assets
components
Changes to any components
components/sheet
Changes to the play mode character sheet
components/wizard
Changes to the character creation wizard
decorators
Changes to the char decorators
helpers
Changes to the helpers
src
Changes to any part of the source code
tests
Involving / related to any tests
views
Changes to the overarching layout views
vue
Involving / related to Vue
vuex
Involving / related to Vuex
labels
Nov 15, 2019
The merging should be handled by the consumer that wants them merged, not by the skill index
Only one wound is caused at a time, so the logic can be simplified.
thislooksfun
force-pushed
the
feature/finish-wizard
branch
from
November 24, 2019 00:25
e310649
to
693584e
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
assets
Changes to static assets
components/sheet
Changes to the play mode character sheet
components/wizard
Changes to the character creation wizard
components
Changes to any components
decorators
Changes to the char decorators
helpers
Changes to the helpers
src
Changes to any part of the source code
tests
Involving / related to any tests
views
Changes to the overarching layout views
vue
Involving / related to Vue
vuex
Involving / related to Vuex
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.