Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

[WIP] Finish the character creation wizard #62

Merged
merged 57 commits into from
Nov 24, 2019

Conversation

thislooksfun
Copy link
Owner

@thislooksfun thislooksfun commented Oct 6, 2019

  • Basic info
  • Attribute points
  • Talents
  • Talent options
  • Spells
  • Knowledge skill(s)
  • Artisan skill
  • Skill ranks
  • Equipment
  • Fleshing out character

@thislooksfun thislooksfun added this to the Beta release milestone Oct 6, 2019
@thislooksfun thislooksfun self-assigned this Oct 6, 2019
@thislooksfun thislooksfun changed the title Finish the character creation wizard [WIP] Finish the character creation wizard Oct 6, 2019
@codecov-io
Copy link

codecov-io commented Oct 6, 2019

Codecov Report

Merging #62 into master will decrease coverage by 7.35%.
The diff coverage is 7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #62      +/-   ##
=========================================
- Coverage   29.85%   22.5%   -7.36%     
=========================================
  Files          44      49       +5     
  Lines         412     600     +188     
  Branches       20      46      +26     
=========================================
+ Hits          123     135      +12     
- Misses        289     465     +176
Flag Coverage Δ
#unittests 22.5% <7%> (-7.36%) ⬇️
Impacted Files Coverage Δ
src/components/characterSheet/index.vue 0% <ø> (ø) ⬆️
src/assets/earthdawn/skills/index.js 66.66% <ø> (ø) ⬆️
...es/Characters/currentCharacter/playMode/actions.js 0% <0%> (ø) ⬆️
src/components/newCharacterWizard/Equipment.vue 0% <0%> (ø)
...es/Characters/currentCharacter/editMode/actions.js 0% <0%> (ø) ⬆️
src/components/newCharacterWizard/SkillRanks.vue 0% <0%> (ø)
src/components/newCharacterWizard/index.vue 0% <0%> (ø) ⬆️
src/store/modules/Characters/editMode/mutations.js 0% <0%> (ø) ⬆️
src/views/CharacterList.vue 0% <0%> (ø) ⬆️
src/components/newCharacterWizard/SpellRanks.vue 0% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc33d2e...693584e. Read the comment docs.

@thislooksfun thislooksfun force-pushed the feature/finish-wizard branch from f0145d6 to c420c01 Compare October 18, 2019 02:02
@todo
Copy link

todo bot commented Nov 13, 2019

Make the effect actually cause an effect when cast on self.

# TODO: Make the effect actually cause an effect when cast on self.
effect: <effect>
areaOfEffect: <area>
successLevels: <on extra success>
extraThreads: <on extra thread>


This comment was generated by todo based on a TODO comment in ab1e64d in #62. cc @thislooksfun.

@todo
Copy link

todo bot commented Nov 13, 2019

Split into helper function

This code pattern is repeated several times in the different asset loaders. It should probably be broken out into a helper function.


// TODO: Split into helper function
// BODY: This code pattern is repeated several times in the different asset
// BODY: loaders. It should probably be broken out into a helper function.
const files = require.context(".", true, /\.yml$/);
const spells = {};


This comment was generated by todo based on a TODO comment in ab1e64d in #62. cc @thislooksfun.

@github-actions github-actions bot added assets Changes to static assets components Changes to any components components/sheet Changes to the play mode character sheet components/wizard Changes to the character creation wizard decorators Changes to the char decorators helpers Changes to the helpers src Changes to any part of the source code tests Involving / related to any tests views Changes to the overarching layout views vue Involving / related to Vue vuex Involving / related to Vuex labels Nov 15, 2019
@thislooksfun thislooksfun merged commit 693584e into master Nov 24, 2019
@thislooksfun thislooksfun deleted the feature/finish-wizard branch November 24, 2019 02:28
@thislooksfun thislooksfun restored the feature/finish-wizard branch November 24, 2019 02:29
@thislooksfun thislooksfun deleted the feature/finish-wizard branch November 24, 2019 02:29
@thislooksfun
Copy link
Owner Author

This was merged because of #110, though it's not quite done yet. The remaining task is tracked in #111.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
assets Changes to static assets components/sheet Changes to the play mode character sheet components/wizard Changes to the character creation wizard components Changes to any components decorators Changes to the char decorators helpers Changes to the helpers src Changes to any part of the source code tests Involving / related to any tests views Changes to the overarching layout views vue Involving / related to Vue vuex Involving / related to Vuex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants