Skip to content
This repository has been archived by the owner on May 31, 2021. It is now read-only.

"Finish" the character creation wizard #110

Merged
merged 61 commits into from
Nov 24, 2019

Conversation

thislooksfun
Copy link
Owner

This finishes enough of the character creation wizard to get basic play out of it.

@thislooksfun thislooksfun added this to the Alpha Release milestone Nov 24, 2019
@github-actions github-actions bot added assets Changes to static assets components Changes to any components components/sheet Changes to the play mode character sheet components/wizard Changes to the character creation wizard decorators Changes to the char decorators helpers Changes to the helpers src Changes to any part of the source code vue Involving / related to Vue vuex Involving / related to Vuex labels Nov 24, 2019
@thislooksfun thislooksfun added the ready-to-merge This PR will be merge automatically once all checks pass. label Nov 24, 2019
@codecov-io
Copy link

codecov-io commented Nov 24, 2019

Codecov Report

Merging #110 into master will decrease coverage by 7.35%.
The diff coverage is 7%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #110      +/-   ##
=========================================
- Coverage   29.85%   22.5%   -7.36%     
=========================================
  Files          44      49       +5     
  Lines         412     600     +188     
  Branches       20      46      +26     
=========================================
+ Hits          123     135      +12     
- Misses        289     465     +176
Flag Coverage Δ
#unittests 22.5% <7%> (-7.36%) ⬇️
Impacted Files Coverage Δ
src/components/characterSheet/index.vue 0% <ø> (ø) ⬆️
src/assets/earthdawn/skills/index.js 66.66% <ø> (ø) ⬆️
...es/Characters/currentCharacter/playMode/actions.js 0% <0%> (ø) ⬆️
src/components/newCharacterWizard/Equipment.vue 0% <0%> (ø)
...es/Characters/currentCharacter/editMode/actions.js 0% <0%> (ø) ⬆️
src/components/newCharacterWizard/SkillRanks.vue 0% <0%> (ø)
src/components/newCharacterWizard/index.vue 0% <0%> (ø) ⬆️
src/store/modules/Characters/editMode/mutations.js 0% <0%> (ø) ⬆️
src/views/CharacterList.vue 0% <0%> (ø) ⬆️
src/components/newCharacterWizard/SpellRanks.vue 0% <0%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc33d2e...b06c7b4. Read the comment docs.

@thislooksfun
Copy link
Owner Author

Manually overriding failures on codecov/patch and codecov/project. Those failures are because new uncovered files were added, and tests have not yet been written (see #21 and #22 for progress).

@thislooksfun thislooksfun merged commit df7d00d into master Nov 24, 2019
@thislooksfun thislooksfun deleted the feature/finish-wizard-alpha branch November 24, 2019 02:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
assets Changes to static assets components/sheet Changes to the play mode character sheet components/wizard Changes to the character creation wizard components Changes to any components decorators Changes to the char decorators helpers Changes to the helpers ready-to-merge This PR will be merge automatically once all checks pass. src Changes to any part of the source code vue Involving / related to Vue vuex Involving / related to Vuex
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants