fix(cassandra) kong refueses to start when a node in contact_points is down
#147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is down Instead of `error(...)`, use `warn(...)` to let kong start. Kong will rediscover the down nodes once they are up.
thibaultcha
reviewed
May 14, 2022
…ing and equal to local_dc Otherwise, consider peer as remote peer. t/14-lb_req_dc_rr.t: remove duplicate Test 9. Update Test 4 to match the code update.
outsinre
force-pushed
the
FTI-4018-lua-cassandra
branch
from
71ca1f0 to
71b9929
Compare
|
@thibaultcha, really appreciate your review. I learned a lot from that. I just update the code according to your suggestions. Would you mind verifying it if available? |
thibaultcha
reviewed
May 18, 2022
| {host = '127.0.0.2', data_center = 'dc1'}, | ||
| {host = '127.0.0.3'} | ||
| {host = '127.0.0.3', data_center = 'dc1'} |
There was a problem hiding this comment.
The patch would be more concise and less disruptive if we keep this test the way it is, only change the expected results.
There was a problem hiding this comment.
I changed this part because the bug is triggered when the first host has no data_center field.
Co-authored-by: Thibault Charbonnier <[email protected]>
1. add newline after `end`. 2. wrap line upon 80 column. 3. remove `error_code: 200` from `.t` test file. 4. remove uncessary piece from Makefile.
bungle
added a commit
to Kong/kong
that referenced
this pull request
May 23, 2022
### Summary > Released on: 2022/05/20 #### Fixed - Improve DC-aware LB policies robustness. [#147](thibaultcha/lua-cassandra#147) - Ensure request-aware + DC-aware LB policy prioritizes local peers over remote ones.
bungle
added a commit
to Kong/kong
that referenced
this pull request
May 24, 2022
### Summary > Released on: 2022/05/20 #### Fixed - Improve DC-aware LB policies robustness. [#147](thibaultcha/lua-cassandra#147) - Ensure request-aware + DC-aware LB policy prioritizes local peers over remote ones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(cassandra) kong refueses to start when a node in
contact_pointsis downInstead of
error(...), usewarn(...)to let kong start. Kong will rediscover the down nodes once they are up.The partner
kong-eePR: https://github.com/Kong/kong-ee/pull/3192